This revision was automatically updated to reflect the committed changes.
Closed by commit rG601687bf731a: [analyzer] DynamicSize: Remove
'getExtent()' from regions (authored by Charusso).
Changed prior to commit:
https://reviews.llvm.org/D69540?vs=227013&id=241447#toc
Repository:
rG LLVM Gi
Charusso added a comment.
Thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69540/new/
https://reviews.llvm.org/D69540
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Fantastic, let's land this!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69540/new/
https://reviews.llvm.org/D69540
___
cfe-commits mailing l
Charusso added inline comments.
Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:158
// symbols to use, only content metadata.
- return nonloc::SymbolVal(SymMgr.getExtentSymbol(FTR));
+ return FTR->getMemRegionManager().getS
Charusso updated this revision to Diff 227013.
Charusso marked 2 inline comments as done.
Charusso added a comment.
- Unpack the issue-solving about code regions.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69540/new/
https://reviews.llvm.org/D69540
Files:
clang/include/clang/Stati
NoQ added inline comments.
Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:158
// symbols to use, only content metadata.
- return nonloc::SymbolVal(SymMgr.getExtentSymbol(FTR));
+ return FTR->getMemRegionManager().getStatic
Charusso added a comment.
Thanks for the review! I am not sure why but after your review I always see the
most appropriate design immediately.
Comment at:
clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:1253-1255
+ MemRegionManager(ASTContext &c, llvm::Bump
Charusso updated this revision to Diff 227006.
Charusso marked 12 inline comments as done.
Charusso added a comment.
- Fix.
- Added a `FIXME` about the missing symbol of `BlockDataRegion`,
`BlockCodeRegion` and `FunctionCodeRegion`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69540/ne
NoQ added inline comments.
Comment at:
clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:1253-1255
+ MemRegionManager(ASTContext &c, llvm::BumpPtrAllocator &a, SValBuilder &SVB,
+ SymbolManager &SymMgr)
+ : Ctx(c), A(a), SVB(SVB), SymMgr(S
Charusso marked 3 inline comments as done.
Charusso added inline comments.
Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:880
uint64_t Length = UINT64_MAX;
- SVal Extent = Top->getExtent(SVB);
+ SVal Extent = Top->getMemRegionManager().getStaticSize(Top);
if (O
Charusso created this revision.
Charusso added a reviewer: NoQ.
Charusso added a project: clang.
Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus,
mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun, mgorny.
This patch introduces a placeholder for representing th
11 matches
Mail list logo
