[PATCH] D69506: [clangd] Add missing highlights for using decls.

This revision was automatically updated to reflect the committed changes. Closed by commit rG94cd2f030324: [clangd] Add missing highlights for using decls. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69506/new/ https://review

[PATCH] D69506: [clangd] Add missing highlights for using decls.

hokein updated this revision to Diff 226851. hokein marked 2 inline comments as done. hokein added a comment. address remaining nits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69506/new/ https://reviews.llvm.org/D69506 Files: clang-tools-ext

[PATCH] D69506: [clangd] Add missing highlights for using decls.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. See the NITs, though Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:51 } + if (auto *USD = dyn_cast(D)) +return kindForDecl(USD->ge

[PATCH] D69506: [clangd] Add missing highlights for using decls.

merge_guards_bot added a comment. Build result: pass - 59702 tests passed, 0 failed and 763 were skipped. Log files: cmake-log.txt , ninja_check_all-log.txt

[PATCH] D69506: [clangd] Add missing highlights for using decls.

hokein added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:51 } + if (auto *UD = dyn_cast(D)) { +if (UD->shadow_size() == 0) ilya-biryukov wrote: > Could we reuse `kindForCandidateDecls` instead? > It's best to keep one wa

[PATCH] D69506: [clangd] Add missing highlights for using decls.

hokein updated this revision to Diff 226673. hokein marked 3 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69506/new/ https://reviews.llvm.org/D69506 Files: clang-tools-extra/cla

[PATCH] D69506: [clangd] Add missing highlights for using decls.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:51 } + if (auto *UD = dyn_cast(D)) { +if (UD->shadow_size() == 0) Could we reuse `kindForCandidateDecls` instead? It's best to keep one way to highlight mul

[PATCH] D69506: [clangd] Add missing highlights for using decls.

merge_guards_bot added a comment. Build result: pass - 59702 tests passed, 0 failed and 763 were skipped. Log files: cmake-log.txt , ninja_check_all-log.txt

[PATCH] D69506: [clangd] Add missing highlights for using decls.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69506 Files: clang-tools-extra/clangd/SemanticHighligh