[PATCH] D69162: [clangd] Remove using-namespace present inside a namespace.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/RemoveUsingNamespace.cpp:179 + + if (ContainingNS) { +for (auto ReDeclNS : ContainingNS->redecls()) usaxena95 wrote: > ilya-biryukov wrote: > > Could you explain why d

[PATCH] D69162: [clangd] Remove using-namespace present inside a namespace.

merge_guards_bot added a comment. Build result: fail - 33521 tests passed, 1 failed and 463 were skipped. failed: LLVM.tools/llvm-objdump/X86/disassemble-functions.test Log files: console-log.txt , CMakeCache

[PATCH] D69162: [clangd] Remove using-namespace present inside a namespace.

usaxena95 marked 3 inline comments as done. usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/RemoveUsingNamespace.cpp:179 + + if (ContainingNS) { +for (auto ReDeclNS : ContainingNS->redecls()) ilya-biryukov wrote: > Coul

[PATCH] D69162: [clangd] Remove using-namespace present inside a namespace.

usaxena95 updated this revision to Diff 227267. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69162/new/ https://reviews.llvm.org/D69162 Files: clang-tools-extra/clangd/refactor/tweaks/RemoveUsingNa

[PATCH] D69162: [clangd] Remove using-namespace present inside a namespace.

ilya-biryukov added a comment. One important question about running on the whole TU in all cases. Other than that LG Comment at: clang-tools-extra/clangd/refactor/tweaks/RemoveUsingNamespace.cpp:110 return false; - if (!dyn_cast(TargetDirective->getDeclContext())) -

[PATCH] D69162: [clangd] Remove using-namespace present inside a namespace.

merge_guards_bot added a comment. Build result: fail - 59446 tests passed, 1 failed and 764 were skipped. failed: libc++.std/thread/thread_mutex/thread_mutex_requirements/thread_mutex_requirements_mutex/thread_mutex_recursive/lock.pass.cpp Log files: console-log.txt

[PATCH] D69162: [clangd] Remove using-namespace present inside a namespace.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/RemoveUsingNamespace.cpp:180 + if (ContainingNS) +findExplicitReferences(ContainingNS, SelectRefToQualify); + else ilya-biryukov wrote: > Do we also need to run in the re

[PATCH] D69162: [clangd] Remove using-namespace present inside a namespace.

usaxena95 updated this revision to Diff 226962. usaxena95 marked 7 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69162/new/ https://reviews.llvm.org/D69162 Files: clang-tool

[PATCH] D69162: [clangd] Remove using-namespace present inside a namespace.

ilya-biryukov added a comment. The most important comment is in the tests. Is there a way to have the same effect with less changes? Comment at: clang-tools-extra/clangd/refactor/tweaks/RemoveUsingNamespace.cpp:47 const UsingDirectiveDecl *TargetDirective = nullptr; + cons

[PATCH] D69162: [clangd] Remove using-namespace present inside a namespace.

merge_guards_bot added a comment. Build result: fail - 33547 tests passed, 1 failed and 464 were skipped. failed: LLVM.tools/llvm-ar/mri-utf8.test Log files: cmake-log.txt , ninja_check_all-log.txt

[PATCH] D69162: [clangd] Remove using-namespace present inside a namespace.

usaxena95 updated this revision to Diff 225596. usaxena95 added a comment. Added additional tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69162/new/ https://reviews.llvm.org/D69162 Files: clang-tools-extra/clangd/refactor/tweaks/RemoveUsi

[PATCH] D69162: [clangd] Remove using-namespace present inside a namespace.

merge_guards_bot added a comment. Build result: fail - 33547 tests passed, 1 failed and 464 were skipped. failed: LLVM.tools/llvm-ar/mri-utf8.test Log files: cmake-log.txt , ninja_check_all-log.txt

[PATCH] D69162: [clangd] Remove using-namespace present inside a namespace.

usaxena95 created this revision. usaxena95 added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, mgrang, jkorous, MaskRay. Herald added a project: clang. This patch extends the removing using-namespace code action to remove using-namespace decl that are prese