This revision was automatically updated to reflect the committed changes.
Closed by commit rGfdccf28697e5: [Driver,ARM] Make -mfloat-abi=soft turn off
MVE. (authored by simon_tatham).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69025/new/
https://
dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.
Yeah, OK. That makes sense.
LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69025/new/
https://reviews.llvm.org/D69025
___
simon_tatham added a comment.
So, as for adding a test ... the test I //have// added here ensures that this
combination of driver options leads to `-target-feature -mve` and `-mve.fp` on
the cc1 command line, and the existing test
`Preprocessor/arm-target-features.c` checks that that in turn le
simon_tatham added a comment.
Yes: this change is in the driver, and causes those features to be disabled on
the command line to cc1, which responds by not defining `__ARM_FEATURE_MVE`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69025/new/
http
dmgreen added a comment.
I do not know this code super well. What happens to the preprocessor in such
cases? Does it disable the relevant macros automatically because we've turned
off the mve and mve.fp features?
Could you add a test?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
simon_tatham created this revision.
simon_tatham added a reviewer: dmgreen.
Herald added subscribers: cfe-commits, kristof.beyls.
Herald added a project: clang.
Since `-mfloat-abi=soft` is taken to mean turning off all uses of the
FP registers, it should turn off the MVE vector instructions as wel
