[PATCH] D69015: [analyzer] Make ExplodedNode identifiers truly stable.

2019-10-17 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ closed this revision. NoQ added a comment. Closed by rC375186 but i forgot the phabricator link :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69015/new/ https://reviews.llvm.org/D69015 ___ cfe-com

[PATCH] D69015: [analyzer] Make ExplodedNode identifiers truly stable.

2019-10-17 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/test/Analysis/exploded-graph-rewriter/node_labels.dot:46 +// COLOR-SAME: Sink Node +// GREY-SAME: Sink Node +// CHECK-SAME: Charusso wrote: > `GREY` typo. Whoops!! CHANGES SINCE LAST ACTION https://revi

[PATCH] D69015: [analyzer] Make ExplodedNode identifiers truly stable.

2019-10-17 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ updated this revision to Diff 225540. NoQ marked an inline comment as done. NoQ added a comment. Fxd. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69015/new/ https://reviews.llvm.org/D69015 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/ExplodedGraph.h clang/lib/

[PATCH] D69015: [analyzer] Make ExplodedNode identifiers truly stable.

2019-10-15 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso added a comment. > i'd much rather enable graph dumping in noassert builds. Totally! When I am not an advanced developer I definitely would like to print the graph with the release pre-built binaries to measure my stuff when I analyze. Like after someone watch your tutorial and starts

[PATCH] D69015: [analyzer] Make ExplodedNode identifiers truly stable.

2019-10-15 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. I was not sure why this is not opaque in case of LLDB usage, but now it is perfect, thanks! Comment at: clang/lib/StaticAnalyzer/Core/ExprEngine.cpp:3079 +

[PATCH] D69015: [analyzer] Make ExplodedNode identifiers truly stable.

2019-10-15 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet. Herald added a project: clang. I need this for the demo at the dev me