This revision was automatically updated to reflect the committed changes.
Closed by commit rGb65fa483058f: [Alignment] Migrate
Attribute::getWith(Stack)Alignment (authored by gchatelet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68792/new/
https
gchatelet updated this revision to Diff 225010.
gchatelet added a comment.
- Fix naming collision
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68792/new/
https://reviews.llvm.org/D68792
Files:
clang/lib/CodeGen/CGCall.cpp
llvm/include/llvm/IR
gchatelet updated this revision to Diff 225006.
gchatelet added a comment.
- Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68792/new/
https://reviews.llvm.org/D68792
Files:
clang/lib/CodeGen/CGCall.cpp
llvm/include/llvm/IR/Att
courbet accepted this revision.
courbet added inline comments.
This revision is now accepted and ready to land.
Comment at: llvm/lib/IR/Core.cpp:2792
+ Attribute AlignAttr =
+ Attribute::getWithAlignment(Call->getContext(), llvm::Align(align));
Call->addAttribute(index,
gchatelet added a comment.
@courbet there's a slight difference in the way the field is serialized in the
mir / ir format (hence not [NFC]) but there's no change in semantics.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68792/new/
https://review
gchatelet created this revision.
gchatelet added a reviewer: courbet.
Herald added subscribers: llvm-commits, cfe-commits, hiraditya, nhaehnle,
jvesely, arsenm.
Herald added a reviewer: jdoerfert.
Herald added projects: clang, LLVM.
This is patch is part of a series to introduce an Alignment type
