[PATCH] D68725: [analyzer] MemoryBlockRegion: Generalize AllocaRegion

2019-10-29 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso added a comment. In D68725#1726332 , @NoQ wrote: > I don't particularly love `SymbolMetadata` because i believe it should be > associated with symbols [...] That is why I secretly wanted to get rid of that concept, but I am fine with using a g

[PATCH] D68725: [analyzer] MemoryBlockRegion: Generalize AllocaRegion

2019-10-29 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso abandoned this revision. Charusso added a comment. In D68725#1726332 , @NoQ wrote: > But i believe that we already have enough concepts and tools here, there's no > need to introduce more of them. F10581160: image.png

[PATCH] D68725: [analyzer] MemoryBlockRegion: Generalize AllocaRegion

2019-10-29 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. In D68725#1724213 , @Charusso wrote: > In D68725#1722136 , @NoQ wrote: > > > Even if `AllocaRegion` didn't store the expression, any path-sensitive > > checker for which such region is "interes

[PATCH] D68725: [analyzer] MemoryBlockRegion: Generalize AllocaRegion

2019-10-28 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso added a comment. Thanks for the notes! In D68725#1722136 , @NoQ wrote: > Generally, there's no need to add more information to `MemRegion` and > `SymExpr` objects [...] Well, that was my first idea, then I saw we allow helper-methods inside r

[PATCH] D68725: [analyzer] MemoryBlockRegion: Generalize AllocaRegion

2019-10-25 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. > This patch generalizes the `AllocaRegion` to store metadata about the > expression of the allocation of a memory block. Mmm, but you can easily obtain that expression from the existing `AllocaRegion`. I.e., you can obtain the expression on which the memory was allocated,

[PATCH] D68725: [analyzer] MemoryBlockRegion: Generalize AllocaRegion

2019-10-09 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso created this revision. Charusso added reviewers: NoQ, xazax.hun. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. This patch generalizes the `AllocaRegion` to store met