[PATCH] D68695: [clang-format] Update noexcept reference qualifiers detection

This revision was automatically updated to reflect the committed changes. krasimir marked an inline comment as done. Closed by commit rGae1b7859cbd6: [clang-format] Update noexcept reference qualifiers detection (authored by krasimir). Changed prior to commit: https://reviews.llvm.org/D68695?vs

[PATCH] D68695: [clang-format] Update noexcept reference qualifiers detection

MyDeveloperDay added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:1499 +} else if (Current.isOneOf(tok::identifier, tok::kw_const, + tok::kw_noexcept) && Current.Previous && krasimir wrote: > MyDevel

[PATCH] D68695: [clang-format] Update noexcept reference qualifiers detection

krasimir marked 3 inline comments as done. krasimir added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:1499 +} else if (Current.isOneOf(tok::identifier, tok::kw_const, + tok::kw_noexcept) && Current.Previous && -

[PATCH] D68695: [clang-format] Update noexcept reference qualifiers detection

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Thank you for fixing this, I'm sorry my review probably wasn't thorough enough in the first place, this LGTM and thank you for the very thorough description as this really help

[PATCH] D68695: [clang-format] Update noexcept reference qualifiers detection

MyDeveloperDay added a comment. Only because I had problem finding the commit, this is as a consequence of D68072: [clang-format] Reference qualifiers in member templates causing extra indentation. Repository: rC Clang CHANGES SINCE LAST ACTION https://re

[PATCH] D68695: [clang-format] Update noexcept reference qualifiers detection

krasimir marked an inline comment as done. krasimir added inline comments. Comment at: unittests/Format/FormatTest.cpp:7093 " template \n" - " int& foo(const std::string& str) const & noexcept {}\n" + " int& foo(const std::string& st

[PATCH] D68695: [clang-format] Update noexcept reference qualifiers detection

krasimir created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. krasimir added reviewers: AndWass, MyDeveloperDay. r373165 fixed an issue where a templated noexcept member function with a reference qualifier would be indented more than expected: // Formatt