[PATCH] D68569: [clang-format] Also look for .{ext}.clang-format file

wanders abandoned this revision. wanders added a comment. In D68569#2019895 , @MyDeveloperDay wrote: > Can we abandon this review now we have the style=file:? Yes, lets abandon this. Comment at: clang/lib/Format/Format.cpp:2606 + au

[PATCH] D68569: [clang-format] Also look for .{ext}.clang-format file

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. Can we abandon this review now we have the style=file:? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68569/new/ https

[PATCH] D68569: [clang-format] Also look for .{ext}.clang-format file

lebedev.ri added a comment. In D68569#1697248 , @wanders wrote: > The "Language" option can not distinguish between C and C++. > > We have projects which contains both C and C++ code. Using different style > (yes..) for C and C++. Our C++ headers are nam

[PATCH] D68569: [clang-format] Also look for .{ext}.clang-format file

MyDeveloperDay added a comment. Comment at: clang/lib/Format/Format.cpp:2603 llvm::SmallVector FilesToLookFor; + Nit: almost every file has an extension should this be 3? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D68569: [clang-format] Also look for .{ext}.clang-format file

wanders added a comment. The "Language" option can not distinguish between C and C++. We have projects which contains both C and C++ code. Using different style (yes..) for C and C++. Our C++ headers are named hpp. In our toplevel we have the following symlinks .c.clang-format -> clang-format/

[PATCH] D68569: [clang-format] Also look for .{ext}.clang-format file

lebedev.ri added a comment. I'm not seeing any merrit this brings over existing https://clang.llvm.org/docs/ClangFormatStyleOptions.html `Language` option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68569/new/ https://reviews.llvm.org/D68569

[PATCH] D68569: [clang-format] Also look for .{ext}.clang-format file

MyDeveloperDay added a comment. Thanks for the patch, I think I understand what you are trying to do, but I have a few questions. Is the premise here that you need slightly different styles for .cpp than for .h? could you explain why? whilst I can see there is value in having such fine control

[PATCH] D68569: [clang-format] Also look for .{ext}.clang-format file

wanders added a comment. This depends on https://reviews.llvm.org/D68568 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68569/new/ https://reviews.llvm.org/D68569 ___ cfe-commits mailing list cfe-commit

[PATCH] D68569: [clang-format] Also look for .{ext}.clang-format file

wanders created this revision. wanders added a reviewer: clang-format. wanders added a project: clang-format. Herald added a project: clang. E.g: When formatting foo.cpp it will look for .cpp.clang-format This makes it easy to different formatting for .c/.h files and .cpp/.hpp files withi