This revision was automatically updated to reflect the committed changes.
arphaman marked 5 inline comments as done.
Closed by commit rGa13f0da1d0bc: [clang-scan-deps] Improve string/character
literal skipping (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D68436?vs=2
kousikk accepted this revision.
kousikk marked an inline comment as done.
kousikk added inline comments.
Comment at: clang/lib/Lex/DependencyDirectivesSourceMinimizer.cpp:206
+if (*First == '\\') {
+ if (++First == End)
+return;
dexonsmith wrote:
dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
LGTM, with a few nitpicks about unnecessary nesting.
Comment at: clang/lib/Lex/DependencyDirectivesSourceMinimizer.cpp:205
+ return;
+if (*First == '\\') {
+
kousikk added inline comments.
Comment at: clang/lib/Lex/DependencyDirectivesSourceMinimizer.cpp:205
+ return;
+if (*First == '\\') {
+ if (++First == End)
Should you also check if the character right after a backslash is equal to
Terminator and if
arphaman created this revision.
arphaman added reviewers: dexonsmith, Bigcheese, aganea, kousikk.
Herald added subscribers: ributzka, tschuett, jkorous.
Herald added a project: clang.
The existing string/character literal skipping code in the dependency
directives source minimizer has two issues:
