[PATCH] D68430: Don't use object libraries with Xcode

jordan_rose closed this revision. jordan_rose added a comment. Committed as rC373769 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68430/new/ https://reviews.llvm.org/D68430 __

[PATCH] D68430: Don't use object libraries with Xcode

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. That's fine. That said, there are things that just can't be done, or don't work well, in the Xcode and Visual Studio generators, so we have precedent for disabling functionality based on those g

[PATCH] D68430: Don't use object libraries with Xcode

jordan_rose updated this revision to Diff 223250. jordan_rose added a comment. Okay, having Xcode force-load the static libraries doesn't seem bad at all. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68430/new/ https://reviews.llvm.org/D68430 Fil

[PATCH] D68430: Don't use object libraries with Xcode

jordan_rose added a comment. In D68430#1693965 , @beanz wrote: > clang_cpp can't link the libraries "normally" because it has no unresolved > symbols to force the contents of the libraries to link. I don't like it, but > I think the best option is to dis

[PATCH] D68430: Don't use object libraries with Xcode

beanz added a comment. In D68430#1693964 , @jordan_rose wrote: > I'm not quite sure //what// it's doing. The executable targets end up trying > to link against the static libraries anyway, which of course haven't been > built. It's possible that this is

[PATCH] D68430: Don't use object libraries with Xcode

jordan_rose added a comment. I'm not quite sure //what// it's doing. The executable targets end up trying to link against the static libraries anyway, which of course haven't been built. It's possible that this is because the LIBTYPE is both STATIC and OBJECT and if it were just OBJECT we might

[PATCH] D68430: Don't use object libraries with Xcode

beanz added a comment. This has the side-effect of making `libclang_cpp` effectively empty when you build with Xcode. What exactly does Xcode do with `OBJECT` libraries? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68430/new/ https://reviews.llv

[PATCH] D68430: Don't use object libraries with Xcode

jordan_rose created this revision. jordan_rose added a reviewer: beanz. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. Undoes some of the effects of D61909 when using the Xcode CMake generator—it doesn't handle object libraries corr