This revision was automatically updated to reflect the committed changes.
Closed by commit rL373318: [clangd] Handle template arguments in
findExplicitReferences (authored by ibiryukov, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68137/new/
https://reviews.llvm.org/D68137
__
ilya-biryukov marked 6 inline comments as done.
ilya-biryukov added inline comments.
Comment at: clang-tools-extra/clangd/FindTarget.cpp:556
+ // We re-define Traverse*, since there's no corresponding Visit*.
+ bool TraverseTemplateArgumentLoc(TemplateArgumentLoc A) {
---
ilya-biryukov updated this revision to Diff 222554.
ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added a comment.
- Restore dlog()
- Check reference to function pointer non-type template parameters in tests
- Extend comment of TraverseTemplateArgumentLoc
Repository:
rG LLVM Gi
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/FindTarget.cpp:556
+ // We re-define Traverse*, since there's no corresponding Visit*.
+ bool TraverseTemplateArgumentLoc(TemplateArgumentLoc A) {
... and we need it because, template templa
ilya-biryukov added inline comments.
Comment at: clang-tools-extra/clangd/FindTarget.cpp:576
+case TemplateArgument::Expression:
+ break; // Handled by visited functions.
+};
This comment is a bit unclear, I'll have to change it.
The idea is that thi
ilya-biryukov created this revision.
ilya-biryukov added a reviewer: kadircet.
Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay.
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D68137
Files:
clang-tools-extra/clangd/FindTarget.cpp
