[PATCH] D68077: [clangd][vscode] Turn on the semantic highlighting by default.

2019-09-26 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL372969: [clangd][vscode] Turn on the semantic highlighting by default. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D68077: [clangd][vscode] Turn on the semantic highlighting by default.

2019-09-26 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68077/new/ https://reviews.llvm.org/D68077 _

[PATCH] D68077: [clangd][vscode] Turn on the semantic highlighting by default.

2019-09-26 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. We have turned on the flag manually and used it for a while, and don't see any major issues, let's enable it by default.