[PATCH] D67888: [clang-format] NFC clang-format the clang-format unit tests

2019-09-23 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL372689: [clang-format] NFC clang-format the clang-format unit tests (authored by paulhoad, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D67888: [clang-format] NFC clang-format the clang-format unit tests

2019-09-23 Thread Owen Pan via Phabricator via cfe-commits
owenpan accepted this revision. owenpan added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67888/new/ https://reviews.llvm.org/D67888 ___ cfe-commits mailing list cfe-comm

[PATCH] D67888: [clang-format] NFC clang-format the clang-format unit tests

2019-09-23 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. In D67888#1678465 , @owenpan wrote: > I suppose the .clang-format file you used only had `BasedOnStyle: LLVM` in > it. Did you run clang-format the second time to ensure that the formatted > file was stable? it used the

[PATCH] D67888: [clang-format] NFC clang-format the clang-format unit tests

2019-09-22 Thread Owen Pan via Phabricator via cfe-commits
owenpan added a comment. I suppose the .clang-format file you used only had `BasedOnStyle: LLVM` in it. Did you run clang-format the second time to ensure that the formatted file was stable? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67888/new/ https://reviews.llvm.org/D67888 __

[PATCH] D67888: [clang-format] NFC clang-format the clang-format unit tests

2019-09-22 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay updated this revision to Diff 221214. MyDeveloperDay added a comment. wrong patch file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67888/new/ https://reviews.llvm.org/D67888 Files: clang/unittests/Format/FormatTest.cpp Index: clang/unittests/Format/FormatTest.cpp ==

[PATCH] D67888: [clang-format] NFC clang-format the clang-format unit tests

2019-09-22 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay created this revision. MyDeveloperDay added reviewers: klimek, owenpan, timwoj. MyDeveloperDay added a project: clang-tools-extra. Herald added a project: clang. It is annoying that the clang-format tests aren't themselves clang-formatted, if you use a format on save option in VS o