[PATCH] D67854: Ensure AtomicExpr goes through SEMA checking after TreeTransform

erichkeane added a comment. In D67854#1678982 , @erichkeane wrote: > In D67854#1678236 , @RKSimon wrote: > > > @erichkeane The atomic-expr.cpp test is failing on some MSVC buildbots, > > please can you take a look?

[PATCH] D67854: Ensure AtomicExpr goes through SEMA checking after TreeTransform

erichkeane added a comment. In D67854#1678236 , @RKSimon wrote: > @erichkeane The atomic-expr.cpp test is failing on some MSVC buildbots, > please can you take a look? > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/

[PATCH] D67854: Ensure AtomicExpr goes through SEMA checking after TreeTransform

RKSimon added a comment. @erichkeane The atomic-expr.cpp test is failing on some MSVC buildbots, please can you take a look? http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/ Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67854/ne

[PATCH] D67854: Ensure AtomicExpr goes through SEMA checking after TreeTransform

This revision was automatically updated to reflect the committed changes. Closed by commit rL372422: Ensure AtomicExpr goes through SEMA checking after TreeTransform (authored by erichkeane, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to co

[PATCH] D67854: Ensure AtomicExpr goes through SEMA checking after TreeTransform

erichkeane created this revision. erichkeane added a reviewer: eli.friedman. Herald added a subscriber: jfb. RebuildAtomicExpr was skipping doing semantic analysis which broke in the cases where the expressions were not dependent. This resulted in the ImplicitCastExpr from an array to a pointer be