rjmccall added inline comments.
Comment at: clang/lib/AST/Mangle.cpp:130
+ return;
+}
+
vsk wrote:
> rjmccall wrote:
> > This is actually backwards, right? A literal label is one that doesn't get
> > the global prefix and therefore potentially needs th
vsk added inline comments.
Comment at: clang/lib/AST/Mangle.cpp:130
+ return;
+}
+
rjmccall wrote:
> This is actually backwards, right? A literal label is one that doesn't get
> the global prefix and therefore potentially needs the `\01` prefix to
> s
rjmccall added inline comments.
Comment at: clang/include/clang/Basic/Attr.td:734
+// TODO: Make it possible to specify this in source.
+BoolArgument<"LiteralLabel">
+ ];
`LiteralLabel` is an unfortunate name for this property because
`getLiteralLabel`
vsk updated this revision to Diff 221391.
vsk marked 3 inline comments as done.
vsk added a comment.
- Address latest review feedback.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67774/new/
https://reviews.llvm.org/D67774
Files:
clang/include/clang/Basic/Attr.td
clang/include/cla
rjmccall added inline comments.
Comment at: clang/include/clang/Basic/Attr.td:725
let Spellings = [Keyword<"asm">, Keyword<"__asm__">];
- let Args = [StringArgument<"Label">];
+ let Args = [StringArgument<"Label">, BoolArgument<"LiteralLabel">];
let SemaHandler = 0;
-
vsk updated this revision to Diff 221066.
vsk retitled this revision from "[Mangle] Check ExternalASTSource before adding
prefix to asm label names" to "[Mangle] Add flag to asm labels to disable
global prefixing".
vsk edited the summary of this revision.
vsk added a comment.
Thanks for your fee
