rnk added a comment.
I guess the commit message shouldn't say "[CodeView] Add option to disable
inline line tables." It's really an option for all debug info. You could put
"[DebugInfo]" on there, or just drop the tag.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://
akhuang updated this revision to Diff 224687.
akhuang added a comment.
- Remove extra ifs.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67723/new/
https://reviews.llvm.org/D67723
Files:
clang/include/clang/Basic/CodeGenOptions.def
clang/inclu
rnk added inline comments.
Comment at: llvm/lib/Transforms/Utils/InlineFunction.cpp:1427
+// Remove debug info intrinsics.
+if (auto *DbgInst = dyn_cast(BI)) {
+ BI = --(DbgInst->eraseFromParent());
Each of these inherit from DbgVariableI
akhuang updated this revision to Diff 224681.
akhuang marked 2 inline comments as done.
akhuang added a comment.
Herald added a subscriber: ormris.
-Remove intrinsics debug info
-Add inliner test
-Add to function attribute description
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACT
rnk added inline comments.
Comment at: clang/include/clang/Driver/Options.td:1943
+def gno_inline_line_tables : Flag<["-"], "gno-inline-line-tables">,
+ Flags<[CC1Option, CoreOption]>, HelpText<"Don't emit inline line tables">;
aprantl wrote:
> As a DWARF pers
aprantl added a comment.
There also needs to be a IR-based test for the inliner change.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67723/new/
https://reviews.llvm.org/D67723
___
cfe-commits mailing
aprantl added inline comments.
Comment at: llvm/lib/Transforms/Utils/InlineFunction.cpp:1426
+ // If we are not generating inline line tables, set the debug
location
+ // of the inlined code to be the call site.
+ DebugLoc IDL =
aprant
aprantl requested changes to this revision.
aprantl added a comment.
This revision now requires changes to proceed.
I don't think the implementation is correct, see inline comments.
Comment at: clang/include/clang/Driver/Options.td:1943
+def gno_inline_line_tables : Flag<["-"],
jmorse added a comment.
Looks good, although I'm not familiar enough with frontend things to approve
IMO.
Using a function attribute seems fine and appropriate too -- although CU flags
is another thing I'm unfamiliar with, so I can't really offer an opinion.
Repository:
rG LLVM Github Monor
akhuang updated this revision to Diff 220756.
akhuang marked 3 inline comments as done.
akhuang added a comment.
- Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67723/new/
https://reviews.llvm.org/D67723
Files:
clang/include/cla
dblaikie added subscribers: JDevlieghere, aprantl.
dblaikie added a comment.
As per the bug - I'm not super inclined towards a function attribute here (&
even if it's going to be an inliner rather than debug info generation/backend
thing (which I'm more on the fence about - think I'm happy with
rnk added a comment.
+ other debug info people
Comment at: llvm/docs/LangRef.rst:1436
function. This can have very system-specific consequences.
+``no-inline-line-tables``
+When this attribute is set to true, inline line tables are not generated
This i
akhuang created this revision.
akhuang added a reviewer: rnk.
Herald added subscribers: llvm-commits, cfe-commits, hiraditya.
Herald added projects: clang, LLVM.
This adds a clang option to disable inline line tables. When it is used,
the inliner uses the call site as the location of the inlined f
13 matches
Mail list logo
