[PATCH] D67585: [clang] [cmake] Make building dylib optional

beanz added a comment. In D67585#1670491 , @mgorny wrote: > But in that case, we should aim for consistency, i.e. remove the matching > option from LLVM. Yes! I want to do that too. After the mono-repo transition is finalized I think we need to invest

[PATCH] D67585: [clang] [cmake] Make building dylib optional

mgorny added a comment. But in that case, we should aim for consistency, i.e. remove the matching option from LLVM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67585/new/ https://reviews.llvm.org/D67585 ___ cfe-commits mailing list cfe-c

[PATCH] D67585: [clang] [cmake] Make building dylib optional

beanz added a reviewer: compnerd. beanz added a comment. In D67585#1670433 , @mgorny wrote: > This is really much more work than disabling the one component I don't need > or care for, especially when I do shared lib build and therefore the > additional

[PATCH] D67585: [clang] [cmake] Make building dylib optional

mgorny added a comment. In D67585#1670422 , @beanz wrote: > In D67585#1670420 , @mgorny wrote: > > > Sure but I want to build-test practically everything else. I wouldn't mind > > if this didn't basically kill my t

[PATCH] D67585: [clang] [cmake] Make building dylib optional

beanz added a comment. In D67585#1670420 , @mgorny wrote: > Sure but I want to build-test practically everything else. I wouldn't mind if > this didn't basically kill my test system by resource exhaustion You can use the ‘LLVM_DISTRIBUTION_COMPONENTS’ o

[PATCH] D67585: [clang] [cmake] Make building dylib optional

mgorny added a comment. Sure but I want to build-test practically everything else. I wouldn't mind if this didn't basically kill my test system by resource exhaustion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67585/new/ https://reviews.llvm.org/D67585 __

[PATCH] D67585: [clang] [cmake] Make building dylib optional

mgorny added a comment. Also note that I'm leaving it enabled by default, so only people explicitly opting out would not be testing it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67585/new/ https://reviews.llvm.org/D67585 ___ cfe-commit

[PATCH] D67585: [clang] [cmake] Make building dylib optional

beanz requested changes to this revision. beanz added a comment. This revision now requires changes to proceed. Please no. You don’t need to build the library. ‘check-clang’ doesn’t depend on it, so it should not impact your build and test cycles. We want it included in the ‘all’ target for ever

[PATCH] D67585: [clang] [cmake] Make building dylib optional

mgorny created this revision. mgorny added reviewers: tstellar, sylvestre.ledru, smeenai, beanz. Similarly to how LLVM dylib can be disabled via LLVM_BUILD_LLVM_DYLIB, introduce CLANG_BUILD_CLANG_DYLIB to make it possible to disable building clang's dylib. This is useful for pure testing environm