[PATCH] D67373: Don't emit .gnu_pubnames when tuning for LLDB

2019-09-10 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL371530: Don't emit .gnu_pubnames when tuning for LLDB. (authored by adrian, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://review

[PATCH] D67373: Don't emit .gnu_pubnames when tuning for LLDB

2019-09-09 Thread David Blaikie via Phabricator via cfe-commits
dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Seems good to me - thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67373/new/ https://reviews.llvm.org/D67373 _

[PATCH] D67373: Don't emit .gnu_pubnames when tuning for LLDB

2019-09-09 Thread Jonas Devlieghere via Phabricator via cfe-commits
JDevlieghere added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3400 if (DwarfFission != DwarfFissionKind::None || - DebuggerTuning == llvm::DebuggerKind::LLDB || (PubnamesArg && checkDebugInfoOption(PubnamesArg, Args, D, TC))) ---

[PATCH] D67373: Don't emit .gnu_pubnames when tuning for LLDB

2019-09-09 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl added a comment. In D67373#1663924 , @dblaikie wrote: > Have you got a link to the original thread where this was discussed/I > mentioned it? Want to page in some context to double-check if I had any ideas > that might've let this simplify things

[PATCH] D67373: Don't emit .gnu_pubnames when tuning for LLDB

2019-09-09 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. Have you got a link to the original thread where this was discussed/I mentioned it? Want to page in some context to double-check if I had any ideas that might've let this simplify things. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D67373: Don't emit .gnu_pubnames when tuning for LLDB

2019-09-09 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl created this revision. aprantl added reviewers: jasonmolenda, dblaikie, friss, emaste, JDevlieghere. Herald added a project: clang. LLDB reads the various `.apple*` accelerator tables which should make `.gnu_pubnames` redundant. This changes the Clang driver to no longer pass `-ggnu-pubn