[PATCH] D67304: Unify checking enumerator values in ObjC, C, and MSVC modes

rnk added a comment. In D67304#1663042 , @hans wrote: > Should there be a test exercising this part? The updated tests both have > -fms-compatibility, so were already just warning. Good point, we aren't testing that this unfixed enum behavior is a part

[PATCH] D67304: Unify checking enumerator values in ObjC, C, and MSVC modes

rnk updated this revision to Diff 219425. rnk added a comment. - rewrite, abandon unification Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67304/new/ https://reviews.llvm.org/D67304 Files: clang/lib/Sema/SemaDecl.cpp clang/test/Sema/Microsoft

[PATCH] D67304: Unify checking enumerator values in ObjC, C, and MSVC modes

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm with comment > The main functional change is that -fno-ms-compatibility now no longer > sends us down the hard error diagnostic code path for ObjC fixed enums. > Instead, complete-but-not-fi

[PATCH] D67304: Unify checking enumerator values in ObjC, C, and MSVC modes

rnk created this revision. rnk added reviewers: hans, rsmith, STL_MSFT. Herald added a project: clang. These three modes need to range check enumerator values differently than C++ does. Before this change, we had two codepaths doing the same thing in two cases: 1. enum complete (ObjC fixed & Micr