[PATCH] D67304: Emit -Wmicrosoft-enum-value warning instead of error in MS ABI

This revision was automatically updated to reflect the committed changes. Closed by commit rL371581: Emit -Wmicrosoft-enum-value warning instead of error in MS ABI (authored by rnk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

[PATCH] D67304: Emit -Wmicrosoft-enum-value warning instead of error in MS ABI

rnk added a comment. In D67304#1664696 , @thakis wrote: > We have the old TODO of changing this warning to be emitted at enum use time > (e.g. when Foo_Val is compared to 0) instead of declaration time. Maybe > that's a better fix. Or is implementing tha

[PATCH] D67304: Emit -Wmicrosoft-enum-value warning instead of error in MS ABI

thakis added a comment. We have the old TODO of changing this warning to be emitted at enum use time (e.g. when Foo_Val is compared to 0) instead of declaration time. Maybe that's a better fix. Or is implementing that very involved? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D67304: Emit -Wmicrosoft-enum-value warning instead of error in MS ABI

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67304/new/ https://reviews.llvm.org/D67304 ___ cfe

[PATCH] D67304: Emit -Wmicrosoft-enum-value warning instead of error in MS ABI

rnk requested review of this revision. rnk added a comment. Ptal, new patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67304/new/ https://reviews.llvm.org/D67304 ___ cfe-commits mailing list cfe-com