[PATCH] D67020: [WebAssembly] Add SIMD QFMA/QFMS

2019-08-30 Thread Thomas Lively via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL370556: [WebAssembly] Add SIMD QFMA/QFMS (authored by tlively, committed by ). Changed prior to commit: https://reviews.llvm.org/D67020?vs=218167&id=218193#toc Repository: rL LLVM CHANGES SINCE LAST

[PATCH] D67020: [WebAssembly] Add SIMD QFMA/QFMS

2019-08-30 Thread Thomas Lively via Phabricator via cfe-commits
tlively added a comment. In D67020#1653403 , @aheejin wrote: > Should we handle these too? > > - There seems to be a generic intrinsic for fused multiply-add: > https://github.com/llvm/llvm-project/blob/d21a3e41a4cfd52e3c5c9341f0b5ce8a173198bf/llvm/includ

[PATCH] D67020: [WebAssembly] Add SIMD QFMA/QFMS

2019-08-30 Thread Heejin Ahn via Phabricator via cfe-commits
aheejin added a comment. Should we handle these too? - There seems to be a generic intrinsic for fused multiply-add: https://github.com/llvm/llvm-project/blob/d21a3e41a4cfd52e3c5c9341f0b5ce8a173198bf/llvm/include/llvm/Target/GenericOpcodes.td#L612-L619 - There are FMA related nodes in ISDOpcode.

[PATCH] D67020: [WebAssembly] Add SIMD QFMA/QFMS

2019-08-30 Thread Thomas Lively via Phabricator via cfe-commits
tlively added a comment. https://github.com/WebAssembly/simd/pull/79/files They need benchmarking data before they can be merged into the proposal, and they need to be supported in the toolchain for us to get good benchmarking data. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D67020: [WebAssembly] Add SIMD QFMA/QFMS

2019-08-30 Thread Heejin Ahn via Phabricator via cfe-commits
aheejin added a comment. Could you point to the spec of these instructions? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67020/new/ https://reviews.llvm.org/D67020 ___ cfe-commits mailing list cfe-com

[PATCH] D67020: [WebAssembly] Add SIMD QFMA/QFMS

2019-08-30 Thread Thomas Lively via Phabricator via cfe-commits
tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: llvm-commits, cfe-commits, sunfish, hiraditya, jgravelle-google, sbc100. Herald added projects: clang, LLVM. Adds clang builtins and LLVM intrinsics for these experimental instructions. They are no