gribozavr marked 2 inline comments as done.
gribozavr added a comment.
Committed as r370337.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66878/new/
https://reviews.llvm.org/D66878
___
cfe-commits mai
ilya-biryukov accepted this revision.
ilya-biryukov marked an inline comment as done.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clang-tools-extra/clangd/index/IndexAction.cpp:217
std::unique_ptr Includes;
+ index::Index
gribozavr marked 4 inline comments as done.
gribozavr added inline comments.
Comment at: clang-tools-extra/clangd/index/IndexAction.cpp:217
std::unique_ptr Includes;
+ index::IndexingOptions Opts;
std::unique_ptr PragmaHandler;
ilya-biryukov wrote:
> Are t
ilya-biryukov added a comment.
Overall LG, thanks! Not sure why we need to keep `IndexingOptions` everywhere,
though, see the relevant comment.
Comment at: clang-tools-extra/clangd/index/IndexAction.cpp:217
std::unique_ptr Includes;
+ index::IndexingOptions Opts;
std::u
gribozavr created this revision.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous.
Herald added a project: clang.
gribozavr added reviewers: ilya-biryukov, jkorous.
Herald added a subscriber: dexonsmith.
gribozavr added a parent revision: D66877: Moved the IndexDataConsumer::finis
