[PATCH] D66876: Indexing: create PP callbacks in the ASTConsumer

2019-08-29 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr added a comment. Committed as r370323. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66876/new/ https://reviews.llvm.org/D66876 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D66876: Indexing: create PP callbacks in the ASTConsumer

2019-08-28 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66876/new/ https://reviews.llvm.org/D66876 _

[PATCH] D66876: Indexing: create PP callbacks in the ASTConsumer

2019-08-28 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr created this revision. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. gribozavr added a parent revision: D66875: [Index] Marked a bunch of classes 'final'. Doing so removes one reason to create a custom FrontendAction. FrontendActions are not desirable b