This revision was automatically updated to reflect the committed changes.
Closed by commit rL370455: [Clangd] ExtractFunction Added checks for broken
control flow (authored by SureYeaah, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit
SureYeaah updated this revision to Diff 218053.
SureYeaah marked 4 inline comments as done.
SureYeaah added a comment.
Addressed review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66732/new/
https://reviews.llvm.org/D66732
Files:
clan
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp:433
+// inside Extraction Zone.
+void incrementLoopSwitchCounters(Stmt *S) {
+
SureYeaah updated this revision to Diff 217881.
SureYeaah added a comment.
Added null statement check in TraverseStmt
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66732/new/
https://reviews.llvm.org/D66732
Files:
clang-tools-extra/clangd/refact
SureYeaah updated this revision to Diff 217865.
SureYeaah added a comment.
Removed selectionTree Visitor
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66732/new/
https://reviews.llvm.org/D66732
Files:
clang-tools-extra/clangd/refactor/tweaks/Ext
SureYeaah created this revision.
SureYeaah added reviewers: sammccall, kadircet.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay,
ilya-biryukov.
Herald added a project: clang.
- Added a SelectionTreeVisitor to check for broken control flow
- Added unittests
Repository:
rG LL
