dexonsmith closed this revision.
dexonsmith marked an inline comment as done.
dexonsmith added a comment.
r370546.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66710/new/
https://reviews.llvm.org/D66710
___
cfe-commits mailing list
cfe-com
bruno accepted this revision.
bruno added a comment.
LGTM!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66710/new/
https://reviews.llvm.org/D66710
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66710/new/
https://reviews.llvm.org/D66710
___
cfe-commits mailing list
cfe-commi
dexonsmith marked 2 inline comments as done.
dexonsmith added inline comments.
Comment at: clang/include/clang/Basic/FileManager.h:320
+ /// twice, you get two new file entries.
+ const FileEntry *getBypassFile(const FileEntry &VFE);
+
bruno wrote:
> Does it ma
dexonsmith updated this revision to Diff 217754.
dexonsmith added a comment.
Added a FileManagerTest and changed FileManager::getBypassFile to use
FileEntryRef.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66710/new/
https://reviews.llvm.org/D66710
Files:
clang/include/clang/Basic/
bruno added a comment.
Nice! Is this something that can be tested for in
`unittests/Basic/FileManagerTest.cpp`?
Comment at: clang/include/clang/Basic/FileManager.h:320
+ /// twice, you get two new file entries.
+ const FileEntry *getBypassFile(const FileEntry &VFE);
+
--
dexonsmith updated this revision to Diff 217229.
dexonsmith added a comment.
New diff with full context.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66710/new/
https://reviews.llvm.org/D66710
Files:
clang/include/clang/Basic/FileManager.h
clang/include/clang/Basic/SourceManager.h
arphaman added a comment.
Missing full context
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66710/new/
https://reviews.llvm.org/D66710
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
dexonsmith created this revision.
dexonsmith added reviewers: rsmith, arphaman, akyrtzi, bruno.
Herald added a subscriber: ributzka.
If contents of a file that is part of a PCM are overridden when reading
it, but weren't overridden when the PCM was being built, the ASTReader
will emit an error. N
