[PATCH] D66592: [clangd] Send suppported codeActionKinds to the client.

2019-08-22 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL369656: [clangd] Send suppported codeActionKinds to the client. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https

[PATCH] D66592: [clangd] Send suppported codeActionKinds to the client.

2019-08-22 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 216625. hokein marked 3 inline comments as done. hokein added a comment. Fix the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66592/new/ https://reviews.llvm.org/D66592 Files: clang-tools-extra/clan

[PATCH] D66592: [clangd] Send suppported codeActionKinds to the client.

2019-08-22 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:467 + // Per LSP, codeActionProvide can be either boolean or CodeActionOptions. + // CodeActio

[PATCH] D66592: [clangd] Send suppported codeActionKinds to the client.

2019-08-22 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. This would make client know which codeActionKinds that clangd may return. VSCode will add a new entry "Refactor..." (which shows all