[PATCH] D66564: [clang-tidy] new performance struct pack align check

aaron.ballman added a comment. I sort of understand why this was asked to be put into `performance`, but I'm not convinced that's the right place to put it. Performance could be degraded by packing structures on some architectures depending on how the objects are accessed. I worry that people w

[PATCH] D66564: [clang-tidy] new performance struct pack align check

ffrankies added a comment. As per the previous discussion, the check has been moved into the `performance` module. In D66564#1670640 , @lebedev.ri wrote: > I, too, don't believe this is FPGA specific; it should likely go into `misc-` > or even `performa

[PATCH] D66564: [clang-tidy] new performance struct pack align check

ffrankies updated this revision to Diff 224803. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66564/new/ https://reviews.llvm.org/D66564 Files: clang-tidy/performance/CMakeLists.txt clang-tidy/performance/PerformanceTidyModule.cpp clang-tidy/performance/StructPackAlignCheck.cpp c

[PATCH] D66564: [clang-tidy] new performance struct pack align check

ffrankies updated this revision to Diff 224802. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66564/new/ https://reviews.llvm.org/D66564 Files: clang-tidy/performance/CMakeLists.txt clang-tidy/performance/PerformanceTidyModule.cpp clang-tidy/performance/StructPackAlignCheck.cpp c

[PATCH] D66564: [clang-tidy] new performance struct pack align check

ffrankies updated this revision to Diff 224799. ffrankies retitled this revision from "[clang-tidy] new FPGA struct pack align check" to "[clang-tidy] new performance struct pack align check". ffrankies edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D665