This revision was automatically updated to reflect the committed changes.
gribozavr marked an inline comment as done.
Closed by commit rL369504: Removed some dead code in BugReporter and related
files (authored by gribozavr, committed by ).
Herald added a project: LLVM.
Herald added a subscriber:
gribozavr marked 2 inline comments as done.
gribozavr added inline comments.
Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:2343
InterExplodedGraphMap ForwardMap;
- TrimmedGraph = OriginalGraph->trim(Nodes, &ForwardMap, &InverseMap);
Szelethus wr
gribozavr updated this revision to Diff 216342.
gribozavr marked an inline comment as done.
gribozavr added a comment.
Updated a comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66473/new/
https://reviews.llvm.org/D66473
Files:
clang/inclu
gribozavr marked an inline comment as done.
gribozavr added inline comments.
Comment at:
clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:408
-public:
- enum Kind { BasicBRKind, PathSensitiveBRKind };
-
NoQ wrote:
> gribozavr wrote:
> > NoQ wro
NoQ accepted this revision.
NoQ added inline comments.
This revision is now accepted and ready to land.
Comment at:
clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:408
-public:
- enum Kind { BasicBRKind, PathSensitiveBRKind };
-
gribozavr wrot
Szelethus added inline comments.
Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:2343
InterExplodedGraphMap ForwardMap;
- TrimmedGraph = OriginalGraph->trim(Nodes, &ForwardMap, &InverseMap);
gribozavr wrote:
> NoQ wrote:
> > Btw these days we stro
Szelethus added a comment.
No way the entire `NodeResolver` is dead code! I spent so much time trying to
understand it! I mean, now that I think about it, we literally deep copy every
`ExplodedNode`, so why would we need the mapping to the original, right?
Wow. Thank you so much for clearing th
