[PATCH] D66348: [ASTImporter] Do not look up lambda classes

2019-08-30 Thread Gabor Marton via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL370461: [ASTImporter] Do not look up lambda classes (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.

[PATCH] D66348: [ASTImporter] Do not look up lambda classes

2019-08-29 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. I was concerned about how this would affect LLDB but after thinking about it I realized that in the DWARF we will just end up with one `DW_TAG_class_type`. Repository: rG LLVM Github Monore

[PATCH] D66348: [ASTImporter] Do not look up lambda classes

2019-08-21 Thread Gabor Marton via Phabricator via cfe-commits
martong added a comment. In D66348#1636564 , @shafik wrote: > I am not enthusiastic about this solution but I need to think about it some > more. > > We can see that p0624r2 > added >

[PATCH] D66348: [ASTImporter] Do not look up lambda classes

2019-08-21 Thread Gabor Marton via Phabricator via cfe-commits
martong updated this revision to Diff 216378. martong added a comment. - Add tests for default constructible and assignable stateless lambdas Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66348/new/ https://reviews.llvm.org/D66348 Files: clang/l

[PATCH] D66348: [ASTImporter] Do not look up lambda classes

2019-08-19 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. I am not enthusiastic about this solution but I need to think about it some more. We can see that p0624r2 added assignable lambdas: bool f1() { auto x = []{} = {}; auto x2 = x; retur

[PATCH] D66348: [ASTImporter] Do not look up lambda classes

2019-08-18 Thread Aleksei Sidorin via Phabricator via cfe-commits
a_sidorin added a comment. Hello Gabor! I think it's a correct solution for the analyzer: usually, we cannot import a lambda until we have to import some enclosing expression - which means that the lambdas are actually not the same. But I'm not so sure about how it can affect the LLDB logic. @s

[PATCH] D66348: [ASTImporter] Do not look up lambda classes

2019-08-16 Thread Gabor Marton via Phabricator via cfe-commits
martong created this revision. martong added a reviewer: a_sidorin. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. Consider this code: void f() { auto L0 = [](