[PATCH] D66328: [DebugInfo] Add debug location to dynamic atexit destructor

probinson added a comment. In D66328#1647094 , @aganea wrote: > In D66328#1647062 , @probinson wrote: > > > I don't see a test for the __cxx_global_array_dtor case? > > > It is actually the `arraydestroy.*` loop tha

[PATCH] D66328: [DebugInfo] Add debug location to dynamic atexit destructor

aganea added a comment. In D66328#1647062 , @probinson wrote: > I don't see a test for the __cxx_global_array_dtor case? It is actually the `arraydestroy.*` loop that is covered (generated by `CodeGenFunction::emitArrayDestroy`), please see `debug-info

[PATCH] D66328: [DebugInfo] Add debug location to dynamic atexit destructor

probinson added a comment. I don't see a test for the __cxx_global_array_dtor case? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66328/new/ https://reviews.llvm.org/D66328 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D66328: [DebugInfo] Add debug location to dynamic atexit destructor

aganea reopened this revision. aganea added a reviewer: hans. aganea added a comment. This revision is now accepted and ready to land. Re-opening this because the previous commit broke Chromium. - Added a new test `debug-info-dest

[PATCH] D66328: [DebugInfo] Add debug location to dynamic atexit destructor

aganea updated this revision to Diff 217298. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66328/new/ https://reviews.llvm.org/D66328 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDeclCXX.cpp test/CodeGenCXX/debug-info-atexit-stub.cpp test/CodeGenCXX/debug-info-destroy-helper.

[PATCH] D66328: [DebugInfo] Add debug location to dynamic atexit destructor

This revision was automatically updated to reflect the committed changes. Closed by commit rL369458: [DebugInfo] Add debug location to dynamic atexit destructor (authored by aganea, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

[PATCH] D66328: [DebugInfo] Add debug location to dynamic atexit destructor

aganea added a comment. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66328/new/ https://reviews.llvm.org/D66328 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D66328: [DebugInfo] Add debug location to dynamic atexit destructor

aganea updated this revision to Diff 216233. aganea marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66328/new/ https://reviews.llvm.org/D66328 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDeclCXX.cpp test/CodeGenCXX/debug-info-atexit-stub.cpp t

[PATCH] D66328: [DebugInfo] Add debug location to dynamic atexit destructor

aganea added inline comments. Comment at: test/CodeGenCXX/debug-info-atexit-stub.cpp:14 + +// CHECK: define internal void @"??__Ff@?1??d@@YAPEAU?$c@UBXZ@YAXXZ"() +// CHECK-SAME: !dbg ![[SUBPROGRAM:[0-9]+]] { probinson wrote: > Do these Windows-mangled names w

[PATCH] D66328: [DebugInfo] Add debug location to dynamic atexit destructor

probinson added inline comments. Comment at: test/CodeGenCXX/debug-info-atexit-stub.cpp:14 + +// CHECK: define internal void @"??__Ff@?1??d@@YAPEAU?$c@UBXZ@YAXXZ"() +// CHECK-SAME: !dbg ![[SUBPROGRAM:[0-9]+]] { Do these Windows-mangled names work on Linux?

[PATCH] D66328: [DebugInfo] Add debug location to dynamic atexit destructor

aganea updated this revision to Diff 216046. aganea marked 4 inline comments as done. aganea added a comment. As requested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66328/new/ https://reviews.llvm.org/D66328 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDeclCXX.cpp test/C

[PATCH] D66328: [DebugInfo] Add debug location to dynamic atexit destructor

aprantl added inline comments. Comment at: test/CodeGen/debug-info-no-location.cpp:4 +// CHECK-NEXT: ret void, !dbg !51 +// CHECK: !48 = distinct !DISubprogram(name: "`dynamic atexit destructor for 'f'", scope: !3, file: !3, line: 16, type: !49, scopeLine: 16, spFlags: DISPFlag

[PATCH] D66328: [DebugInfo] Add debug location to dynamic atexit destructor

rnk added a comment. I'd be happy to take this patch, address the comments, and land it, if you don't want to deal with all the nits. Comment at: test/CodeGen/debug-info-no-location.cpp:1 +// RUN: %clang -cc1 -emit-llvm %s -gcodeview -debug-info-kind=limited -o - | FileCheck

[PATCH] D66328: [DebugInfo] Add debug location to dynamic atexit destructor

probinson added a comment. "debug-info-no-location.cpp" is an extremely generic name for a very specific case. "debug-info-atexit-stub.cpp" would be better. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66328/new/ https://reviews.llvm.org/D66328

[PATCH] D66328: [DebugInfo] Add debug location to dynamic atexit destructor

aprantl requested changes to this revision. aprantl added inline comments. This revision now requires changes to proceed. Comment at: test/CodeGen/debug-info-no-location.cpp:4 +// CHECK-NEXT: ret void, !dbg !51 +// CHECK: !48 = distinct !DISubprogram(name: "`dynamic atexit destru

[PATCH] D66328: [DebugInfo] Add debug location to dynamic atexit destructor

aganea created this revision. aganea added reviewers: rnk, aprantl. aganea added a project: clang. Previously, when clang was compiled with -DLLVM_ENABLE_ASSERTIONS=ON, the attached test was yielding: inlinable function call in a function with debug info must have a !dbg location call voi