[PATCH] D66254: Correct include suggestion when search path includes symlink

puremourning added a comment. In D66254#1630283 , @puremourning wrote: > In D66254#1630277 , @lebedev.ri > wrote: > > > Tests? > > > Per my comment: I haven't added new tests to HeaderSearchTest.cc because the >

[PATCH] D66254: Correct include suggestion when search path includes symlink

puremourning added a comment. In D66254#1630277 , @lebedev.ri wrote: > Tests? Per my comment: I haven't added new tests to HeaderSearchTest.cc because the InMemoryFileSystem doesn't support symlinks and I didn't want to try and implement that for this

[PATCH] D66254: Correct include suggestion when search path includes symlink

lebedev.ri added a comment. Tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66254/new/ https://reviews.llvm.org/D66254 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D66254: Correct include suggestion when search path includes symlink

puremourning added a comment. FYI this fixes the issue in https://github.com/clangd/clangd/issues/124 I haven't added new tests to HeaderSearchTest.cc because the InMemoryFileSystem doesn't support symlinks and I didn't want to try and implement that for this patch. Let me know thoughts on alte

[PATCH] D66254: Correct include suggestion when search path includes symlink

puremourning created this revision. puremourning added a reviewer: sammccall. Herald added subscribers: cfe-commits, kadircet, ilya-biryukov. Herald added a project: clang. puremourning added a comment. FYI this fixes the issue in https://github.com/clangd/clangd/issues/124 I haven't added new te