This revision was automatically updated to reflect the committed changes.
Closed by commit rL369075: [clang-doc] Serialize inherited attributes and
methods (authored by DiegoAstiazaran, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
DiegoAstiazaran updated this revision to Diff 215506.
DiegoAstiazaran added a comment.
Rebase to master
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66238/new/
https://reviews.llvm.org/D66238
Files:
clang-tools-extra/clang-doc/BitcodeReader.cpp
clang-tools-extra/clang-doc/BitcodeW
DiegoAstiazaran added inline comments.
Comment at: clang-tools-extra/clang-doc/Serialize.cpp:436
+ if (const CXXRecordDecl *Base =
+ cast_or_null(Ty->getDecl()->getDefinition())) {
+bool IsVirtual = false;
juliehockett wrote:
> Will `get
DiegoAstiazaran updated this revision to Diff 215304.
DiegoAstiazaran marked 11 inline comments as done.
DiegoAstiazaran added a comment.
Increase version number of clang-doc bitcode.
Rename `documentInfo` function to `shouldSerializeInfo`.
In new `parseBases` a BaseRecordInfo object is created an
juliehockett added inline comments.
Comment at: clang-tools-extra/clang-doc/BitcodeWriter.h:33
// BitCodeConstants, though they can be added without breaking it.
static const unsigned VersionNumber = 2;
I definitely haven't been particularly good about bumpin
DiegoAstiazaran created this revision.
DiegoAstiazaran added reviewers: juliehockett, jakehehrlich.
DiegoAstiazaran added a project: clang-tools-extra.
Herald added subscribers: kadircet, arphaman.
clang-doc now serializes the inherited attributes and methods, not only the
name of the base class.
