[PATCH] D66143: Don't use std::errc

thakis added a comment. FWIW it looks like 4.8 support is going away in days, not weeks, see D66188 . Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66143/new/ https://reviews.llvm.org/D66143

[PATCH] D66143: Don't use std::errc

This revision was automatically updated to reflect the committed changes. Closed by commit rL368739: Don't use std::errc (authored by ABataev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D66143: Don't use std::errc

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Should we revert the change in lld then? LLVM has a global policy for this; if 4.8 is still supported then regex can't be used yet. Please mention in the commit message that this is a workarou

[PATCH] D66143: Don't use std::errc

jfb added a comment. In D66143#1627226 , @lebedev.ri wrote: > In D66143#1627221 , @ABataev wrote: > > > In D66143#1627195 , @thakis wrote: > > > > > As far as I know 4.8 is n

[PATCH] D66143: Don't use std::errc

lebedev.ri added a comment. In D66143#1627221 , @ABataev wrote: > In D66143#1627195 , @thakis wrote: > > > As far as I know 4.8 is no longer supported. > > > > In D66143#1627168

[PATCH] D66143: Don't use std::errc

ABataev added a comment. In D66143#1627195 , @thakis wrote: > As far as I know 4.8 is no longer supported. > > In D66143#1627168 , @ABataev wrote: > > > In D66143#1627165 , @

[PATCH] D66143: Don't use std::errc

thakis added a comment. As far as I know 4.8 is no longer supported. In D66143#1627168 , @ABataev wrote: > In D66143#1627165 , @thakis wrote: > > > That's Trusty and Trusty is on 4.8 which we no longer support, rig

[PATCH] D66143: Don't use std::errc

ABataev added a comment. Also, there is a clang unit test that fails because of the same reason. Can I include the changes in this test into this patch too or better to make a separate patch? The test is `unittests/Basic/FileManagerTest.cpp` Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D66143: Don't use std::errc

xbolva00 added a comment. GCC 4.8 is still supported Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66143/new/ https://reviews.llvm.org/D66143 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D66143: Don't use std::errc

xbolva00 added a comment. This small change is okay anyway Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66143/new/ https://reviews.llvm.org/D66143 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D66143: Don't use std::errc

ABataev added a comment. In D66143#1627165 , @thakis wrote: > That's Trusty and Trusty is on 4.8 which we no longer support, right? It is still supported with some extra cmake flags. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D66143: Don't use std::errc

thakis added a comment. That's Trusty and Trusty is on 4.8 which we no longer support, right? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66143/new/ https://reviews.llvm.org/D66143 ___ cfe-commits mailing list cfe-

[PATCH] D66143: Don't use std::errc

ABataev added a comment. `std::error_code` works correctly, it is `std::make_error_code` leads to something strange in some cases. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66143/new/ https://reviews.llvm.org/D66143 ___

[PATCH] D66143: Don't use std::errc

ABataev added a comment. In D66143#1627157 , @thakis wrote: > This isn't in a hot codepath, so the virtual calls aren't super important. > > This not working in some libstdc++s is important of course, but llvm's Errc.h > claims "std::error_code works OK o

[PATCH] D66143: Don't use std::errc

thakis added a comment. This isn't in a hot codepath, so the virtual calls aren't super important. This not working in some libstdc++s is important of course, but llvm's Errc.h claims "std::error_code works OK on all platforms we use". I guess that's not true? Can you include more details on wh

[PATCH] D66143: Don't use std::errc

ABataev created this revision. ABataev added reviewers: thakis, rnk. Herald added a project: clang. As noted on Errc.h: // * std::errc is just marked with is_error_condition_enum. This means that // common patters like AnErrorCode == errc::no_such_file_or_directory take // 4 virtual calls ins