[PATCH] D66074: [clangd] Drop diags from non-written #include.

hokein added a comment. In D66074#1626932 , @hans wrote: > > thanks for the information, I suspect that this patch may depend on > > rL367303 (which is not merged in the > > release), I will double check. > > Yes, that

[PATCH] D66074: [clangd] Drop diags from non-written #include.

hans added a comment. > thanks for the information, I suspect that this patch may depend on rL367303 > (which is not merged in the release), I > will double check. Yes, that seems to be it. I've merged that, and then I could merge this one in r368683. Repo

[PATCH] D66074: [clangd] Drop diags from non-written #include.

hokein added a comment. In D66074#1626856 , @hans wrote: > In D66074#1624885 , @hokein wrote: > > > @hans is there still any chance to merge this patch into the release? > > > I tried to merge this to release_90, bu

[PATCH] D66074: [clangd] Drop diags from non-written #include.

hans added a comment. In D66074#1624885 , @hokein wrote: > @hans is there still any chance to merge this patch into the release? I tried to merge this to release_90, but I got a test failure. Does this rely on more patches that need merging? Can you try

[PATCH] D66074: [clangd] Drop diags from non-written #include.

hokein marked an inline comment as done. hokein added a subscriber: hans. hokein added a comment. @hans is there still any chance to merge this patch into the release? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66074/new/ https://reviews.llvm.org/D66074

[PATCH] D66074: [clangd] Drop diags from non-written #include.

This revision was automatically updated to reflect the committed changes. Closed by commit rL368549: [clangd] Drop diags from non-written #include. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://review

[PATCH] D66074: [clangd] Drop diags from non-written #include.

hokein updated this revision to Diff 214590. hokein marked an inline comment as done. hokein added a comment. Add a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66074/new/ https://reviews.llvm.org/D66074 Files: clang-tools-extra/clangd

[PATCH] D66074: [clangd] Drop diags from non-written #include.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM, thanks! We should also merge this into the release branch if it's not too late yet. Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:95

[PATCH] D66074: [clangd] Drop diags from non-written #include.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. This would fix that we show weird diagnostics on random lines of the main file. Repository: rG LLVM Github Monorepo https://revi