[PATCH] D65925: [clang-format] Add SpaceInEmptyBlock option for WebKit

2019-08-10 Thread Owen Pan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL368507: [clang-format] Add SpaceInEmptyBlock option for WebKit (authored by owenpan, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https

[PATCH] D65925: [clang-format] Add SpaceInEmptyBlock option for WebKit

2019-08-10 Thread Owen Pan via Phabricator via cfe-commits
owenpan added a comment. In D65925#1623965 , @thakis wrote: > https://webkit.org/code-style-guidelines/ has one instance of `{ }` with a > space and one of `{}` without a space, and as far as I can tell no text that > says which instance is correct. Are

[PATCH] D65925: [clang-format] Add SpaceInEmptyBlock option for WebKit

2019-08-10 Thread Owen Pan via Phabricator via cfe-commits
owenpan updated this revision to Diff 214509. owenpan added a comment. Changed "may" to "will" and updated the diff. (Should we do the same for the SpaceInEmptyParentheses option?) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65925/new/ https://reviews.llvm.org

[PATCH] D65925: [clang-format] Add SpaceInEmptyBlock option for WebKit

2019-08-09 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. https://webkit.org/code-style-guidelines/ has one instance of `{ }` with a space and one of `{}` without a space, and as far as I can tell no text that says which instance is correct. Are you sure this is the right thing for webkit style? Repository: rC Clang CHANGE

[PATCH] D65925: [clang-format] Add SpaceInEmptyBlock option for WebKit

2019-08-09 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/docs/ClangFormatStyleOptions.rst:2120 +**SpaceInEmptyBlock** (``bool``) + If ``true``, spaces may be inserted into ``{}``. + may