This revision was automatically updated to reflect the committed changes.
Closed by commit rL368070: [clang-doc] Add index in each info html file
(authored by DiegoAstiazaran, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https:/
juliehockett accepted this revision.
juliehockett added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65690/new/
https://reviews.llvm.org/D65690
___
cfe-commits mailing list
c
DiegoAstiazaran added inline comments.
Comment at: clang-tools-extra/clang-doc/Generators.cpp:79
+
+bool Generator::createResources(ClangDocContext &CDCtx) {
+ std::error_code OK;
juliehockett wrote:
> Why is this implementation in the generic Generator? It's fa
DiegoAstiazaran updated this revision to Diff 213513.
DiegoAstiazaran marked 3 inline comments as done.
DiegoAstiazaran added a comment.
Moved serialization of Index to HTML generator.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65690/new/
https://reviews.llvm.org/D65690
Files:
cla
juliehockett added inline comments.
Comment at: clang-tools-extra/clang-doc/Generators.cpp:79
+
+bool Generator::createResources(ClangDocContext &CDCtx) {
+ std::error_code OK;
Why is this implementation in the generic Generator? It's fairly HTML-specific
-- ne
DiegoAstiazaran updated this revision to Diff 213171.
DiegoAstiazaran marked 2 inline comments as done.
DiegoAstiazaran added a comment.
Fix format of index.js file
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65690/new/
https://reviews.llvm.org/D65690
Files:
clang-tools-extra/clang
DiegoAstiazaran added inline comments.
Comment at: clang-tools-extra/clang-doc/assets/index.js:17
+ return FilePath.substring(Path.length + 1)
+ Path = Path.substring(0, Path.lastIndexOf("/"));
+ }
phosek wrote:
> Wrong indentation?
Yes, clang-format "
phosek added inline comments.
Comment at: clang-tools-extra/clang-doc/assets/index.js:17
+ return FilePath.substring(Path.length + 1)
+ Path = Path.substring(0, Path.lastIndexOf("/"));
+ }
Wrong indentation?
CHANGES SINCE LAST ACTION
https://review
DiegoAstiazaran created this revision.
DiegoAstiazaran added reviewers: jakehehrlich, juliehockett, phosek.
DiegoAstiazaran added a project: clang-tools-extra.
Herald added subscribers: kadircet, arphaman, mgrang, mgorny.
An index structure is created while generating the output file for each info
