[PATCH] D65405: [Parser] Use special definition for pragma annotations

2019-08-02 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff added a comment. > LGTM, although I don't think it would be ridiculous to make this an inline > function definition like isAnnotation. Thank you! The fix for `isAnnotation` is D65670 . Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews

[PATCH] D65405: [Parser] Use special definition for pragma annotations

2019-08-01 Thread Serge Pavlov via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL367575: [Parser] Use special definition for pragma annotations (authored by sepavloff, committed by ). Herald added a proj

[PATCH] D65405: [Parser] Use special definition for pragma annotations

2019-07-31 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. LGTM, although I don't think it would be ridiculous to make this an inline function definition like `isAnnotation`. (I like your generated implementation much better than the sequential `if`s used there, though.) Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D65405: [Parser] Use special definition for pragma annotations

2019-07-29 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff created this revision. sepavloff added reviewers: rsmith, rjmccall. Herald added a reviewer: jdoerfert. Herald added a project: clang. Previously pragma annotation tokens were described as any other annotations in TokenKinds.def. This change introduces special macro PRAGMA_ANNOTATION for