[PATCH] D65337: [clangd] Disallow extraction of expression-statements.

This revision was automatically updated to reflect the committed changes. Closed by commit rL368500: [clangd] Disallow extraction of expression-statements. (authored by sammccall, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: htt

[PATCH] D65337: [clangd] Disallow extraction of expression-statements.

sammccall marked 6 inline comments as done. sammccall added a comment. In D65337#1604324 , @SureYeaah wrote: > What was the bug in getCallExpr() ? It could find calls where the DeclRef was an arbitrary subexpression of the callee, not exactly the callee

[PATCH] D65337: [clangd] Disallow extraction of expression-statements.

sammccall updated this revision to Diff 212433. sammccall added a comment. Add basic test for outerImplicit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65337/new/ https://reviews.llvm.org/D65337 Files: clang-tools-extra/clangd/Selection.cpp

[PATCH] D65337: [clangd] Disallow extraction of expression-statements.

sammccall updated this revision to Diff 212432. sammccall marked 2 inline comments as done. sammccall added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65337/new/ https://reviews.llvm.org/D65337 Files: clang

[PATCH] D65337: [clangd] Disallow extraction of expression-statements.

SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:329 while(a < [[1]]) -[[a++]]; +a++; // do while Change to a=[[1]];? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D65337: [clangd] Disallow extraction of expression-statements.

SureYeaah added a comment. What was the bug in getCallExpr() ? Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:391 +return false; + Outer->dumpColor(); + // Blacklist the most common places where an expr can appear but be unused.

[PATCH] D65337: [clangd] Disallow extraction of expression-statements.

sammccall created this revision. sammccall added a reviewer: SureYeaah. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. I split out the "extract parent instead of this" logic from the "this isn't worth extracting" logic (n