[PATCH] D65212: [analyzer] Fix exporting SARIF files from scan-build on Windows

jranieri-grammatech marked an inline comment as done. jranieri-grammatech added inline comments. Comment at: clang/tools/scan-build/libexec/ccc-analyzer:121 END { - if (defined $ResultFile && -z $ResultFile) { unlink($ResultFile); NoQ wrote: > Whoops. I su

[PATCH] D65212: [analyzer] Fix exporting SARIF files from scan-build on Windows

NoQ added inline comments. Comment at: clang/tools/scan-build/libexec/ccc-analyzer:121 END { - if (defined $ResultFile && -z $ResultFile) { unlink($ResultFile); Whoops. I suspect that we're now unconditionally deleting all plist output, which isn't exactl

[PATCH] D65212: [analyzer] Fix exporting SARIF files from scan-build on Windows

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit on your behalf in r366941, thank you for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65212/new/ https://reviews.llvm.org/D65212 _

[PATCH] D65212: [analyzer] Fix exporting SARIF files from scan-build on Windows

jranieri-grammatech added a comment. In D65212#1599841 , @aaron.ballman wrote: > LGTM! Do you need someone to commit on your behalf? Please. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65212/new/ https

[PATCH] D65212: [analyzer] Fix exporting SARIF files from scan-build on Windows

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Do you need someone to commit on your behalf? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65212/new/ https://reviews.llvm.org/D65212 ___

[PATCH] D65212: [analyzer] Fix exporting SARIF files from scan-build on Windows

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65212/new/ https://reviews.llvm.org/D65212 ___ c

[PATCH] D65212: [analyzer] Fix exporting SARIF files from scan-build on Windows

jranieri-grammatech updated this revision to Diff 211578. jranieri-grammatech added a comment. Update an additional place that used -z. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65212/new/ https://reviews.llvm.org/D65212 Files: clang/tools/s

[PATCH] D65212: [analyzer] Fix exporting SARIF files from scan-build on Windows

jordan_rose added a comment. Oops. It looks like there's another place where this pattern shows up (see rC139382 ). The other one should probably be changed as well. (Thanks for diverging from test(1), perl…) Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D65212: [analyzer] Fix exporting SARIF files from scan-build on Windows

jranieri-grammatech created this revision. jranieri-grammatech added reviewers: NoQ, jordan_rose, dcoughlin, george.karpenkov, aaron.ballman. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald a