[PATCH] D65210: [clangd] Fix the annotate tweak after rL366893

2019-07-25 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 211692. hokein marked 2 inline comments as done. hokein added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65210/new/ https://reviews.llvm.org/D65210 Files: clang-tools-extra/clan

[PATCH] D65210: [clangd] Fix the annotate tweak after rL366893

2019-07-25 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL366996: [clangd] Fix the annotate tweak after rL366893 (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://review

[PATCH] D65210: [clangd] Fix the annotate tweak after rL366893

2019-07-24 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/refactor/tweaks/AnnotateHighlightings.cpp:31 InterestedDecl = N->ASTNode.get(); return InterestedDecl; } --

[PATCH] D65210: [clangd] Fix the annotate tweak after rL366893

2019-07-24 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. After rL366893 , the annoate tweak is not activated when we select the whole file (the