This revision was automatically updated to reflect the committed changes.
Closed by commit rL366884: [CrossTU] Add a function to retrieve original source
location. (authored by balazske, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit
balazske updated this revision to Diff 211454.
balazske added a comment.
Update diff to one commit with all changes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65064/new/
https://reviews.llvm.org/D65064
Files:
clang/include/clang/AST/ASTImpor
balazske marked an inline comment as done.
balazske added inline comments.
Comment at: clang/include/clang/CrossTU/CrossTranslationUnit.h:175
+ /// returned.
+ llvm::Optional>
+ getImportedFromSourceLocation(const clang::SourceLocation &ToLoc) const;
It would
balazske added inline comments.
Comment at: clang/lib/CrossTU/CrossTranslationUnit.cpp:476
+ NewImporter->setFileIDImportHandler(
+ [this, Unit](FileID ToID, FileID FromID, ASTImporter &Importer) {
+assert(ImportedFileIDs.find(ToID) == ImportedFileIDs.end() &&
-
balazske updated this revision to Diff 211059.
balazske marked an inline comment as done.
balazske added a comment.
Removed ASTImporter from "callback" function.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65064/new/
https://reviews.llvm.org/D650
martong added inline comments.
Comment at: clang/lib/CrossTU/CrossTranslationUnit.cpp:476
+ NewImporter->setFileIDImportHandler(
+ [this, Unit](FileID ToID, FileID FromID, ASTImporter &Importer) {
+assert(ImportedFileIDs.find(ToID) == ImportedFileIDs.end() &&
--
martong accepted this revision.
martong added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65064/new/
https://reviews.llvm.org/D65064
balazske created this revision.
Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp.
Herald added a reviewer: martong.
Herald added a reviewer: shafik.
Herald added a project: clang.
A new function will be added to get the original SourceLocation
for a SourceLocation that was impor
