[PATCH] D65000: [ARM] Set default alignment to 64bits

This revision was automatically updated to reflect the committed changes. Closed by commit rL368288: [ARM] Set default alignment to 64bits (authored by dnsampaio, committed by ). Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65000/new/ https://reviews.llvm.org/D650

[PATCH] D65000: [ARM] Set default alignment to 64bits

thegameg added a comment. In D65000#1616368 , @dnsampaio wrote: > I have tested this in our MacOS and linux environments. @thakis @thegameg > @phosek, would it be possible for you to check if this works for you? I just built trunk with this patch applie

[PATCH] D65000: [ARM] Set default alignment to 64bits

dnsampaio added a comment. I have tested this in our MacOS and linux environments. @thakis @thegameg @phosek, would it be possible for you to check if this works for you? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65000/new/ https://reviews.llvm.org/D65000

[PATCH] D65000: [ARM] Set default alignment to 64bits

dnsampaio updated this revision to Diff 213540. dnsampaio added a comment. Fix test Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65000/new/ https://reviews.llvm.org/D65000 Files: lib/Basic/Targets/ARM.cpp test/CodeGenCXX/ARM/exception-alignment.cpp test/S

[PATCH] D65000: [ARM] Set default alignment to 64bits

dnsampaio reopened this revision. dnsampaio added a comment. This revision is now accepted and ready to land. Hi, first thanks for those that looked into this and sorry for the delay. We have investigated the errors and seems that the test was, first in the wrong folder, inside CodeGen where it s

[PATCH] D65000: [ARM] Set default alignment to 64bits

phosek added a comment. Reverted in rL367166 . Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65000/new/ https://reviews.llvm.org/D65000 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D65000: [ARM] Set default alignment to 64bits

phosek added inline comments. Comment at: cfe/trunk/test/CodeGen/ARM/exception-alignment.cpp:9 +// A16-NEXT: store <2 x i64> , <2 x i64>* [[BC]], align 16 +#include + thegameg wrote: > thakis wrote: > > This fails on some bots: > > > > http://lab.llvm.org:8011/

[PATCH] D65000: [ARM] Set default alignment to 64bits

thegameg added inline comments. Comment at: cfe/trunk/test/CodeGen/ARM/exception-alignment.cpp:9 +// A16-NEXT: store <2 x i64> , <2 x i64>* [[BC]], align 16 +#include + thakis wrote: > This fails on some bots: > > http://lab.llvm.org:8011/builders/clang-atom-d5

[PATCH] D65000: [ARM] Set default alignment to 64bits

thakis added inline comments. Comment at: cfe/trunk/test/CodeGen/ARM/exception-alignment.cpp:9 +// A16-NEXT: store <2 x i64> , <2 x i64>* [[BC]], align 16 +#include + This fails on some bots: http://lab.llvm.org:8011/builders/clang-atom-d525-fedora-rel/builds/2

[PATCH] D65000: [ARM] Set default alignment to 64bits

This revision was automatically updated to reflect the committed changes. Closed by commit rL367119: [ARM] Set default alignment to 64bits (authored by simpal01, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D65000: [ARM] Set default alignment to 64bits

pirama accepted this revision. pirama added a comment. LGTM for Android. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65000/new/ https://reviews.llvm.org/D65000 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D65000: [ARM] Set default alignment to 64bits

peter.smith accepted this revision. peter.smith added a comment. This revision is now accepted and ready to land. I've not seen any objections so I've approved LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65000/new/ https://reviews.llvm.org/D65000 _

[PATCH] D65000: [ARM] Set default alignment to 64bits

carwil added a comment. In D65000#1595920 , @peter.smith wrote: > test case missing A8 aside this looks ok to me. Would like to see if there > are any comments from the Pacific time zone. Are you happy to approve this now @peter.smith? Repository: r

[PATCH] D65000: [ARM] Set default alignment to 64bits

dnsampaio marked an inline comment as done. dnsampaio added a comment. True. Thx again. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65000/new/ https://reviews.llvm.org/D65000 ___ cfe-commits mailing list cfe-commit

[PATCH] D65000: [ARM] Set default alignment to 64bits

dnsampaio updated this revision to Diff 211132. dnsampaio added a comment. - Joined assignments for default alignments and neon_vector alignment - Added missing align 8 test Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65000/new/ https://reviews.llvm.org/D65000

[PATCH] D65000: [ARM] Set default alignment to 64bits

peter.smith added a comment. test case missing A8 aside this looks ok to me. Would like to see if there are any comments from the Pacific time zone. Comment at: test/CodeGen/ARM/exception-alignment.cpp:8 +// A16-NEXT: store <2 x i64> , <2 x i64>* [[BC]], align 16 +#include +

[PATCH] D65000: [ARM] Set default alignment to 64bits

dnsampaio updated this revision to Diff 211103. dnsampaio added a comment. - Joined assignments for default alignments and neon_vector alignment Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65000/new/ https://reviews.llvm.org/D65000 Files: lib/Basic/Targets/A

[PATCH] D65000: [ARM] Set default alignment to 64bits

peter.smith added a comment. Thanks for the update. Will be worth adding some reviewers from Apple to see if this change should be IsAAPCS only. I've no more further comments myself besides a small nit on style. Comment at: lib/Basic/Targets/ARM.cpp:331 + // but Android

[PATCH] D65000: [ARM] Set default alignment to 64bits

dnsampaio marked 2 inline comments as done. dnsampaio added a comment. Set android-abi default to 128. Added tests for android and not-android. Comment at: lib/Basic/Targets/ARM.cpp:311 // Maximum alignment for ARM NEON data types should be 64-bits (AAPCS) if (IsAAPCS &

[PATCH] D65000: [ARM] Set default alignment to 64bits

dnsampaio updated this revision to Diff 211034. dnsampaio added a comment. - Set androideabi alignment to 128 bits Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65000/new/ https://reviews.llvm.org/D65000 Files: lib/Basic/Targets/ARM.cpp test/CodeGen/ARM/exce

[PATCH] D65000: [ARM] Set default alignment to 64bits

peter.smith added reviewers: srhines, danalbert. peter.smith added a comment. I think that this may not apply for Android as AFAIK their ABI still requires 128-bit alignment in some cases. Adding some more reviewers from Android. Comment at: lib/Basic/Targets/ARM.cpp:311

[PATCH] D65000: [ARM] Set default alignment to 64bits

dnsampaio created this revision. dnsampaio added reviewers: ostannard, dmgreen. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. The maximum alignment used by ARM arch is 64bits, not 128. This could cause overaligned memory access for 128 bit neon