[PATCH] D64712: [clangd] Refactor background-index shard loading

This revision was automatically updated to reflect the committed changes. Closed by commit rL366458: [clangd] Refactor background-index shard loading (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

[PATCH] D64712: [clangd] Refactor background-index shard loading

kadircet updated this revision to Diff 210589. kadircet marked an inline comment as done. kadircet added a comment. - Get rid of CachedShard Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64712/new/ https://reviews.llvm.org/D64712 Files: clang-to

[PATCH] D64712: [clangd] Refactor background-index shard loading

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/BackgroundIndexLoader.cpp:93 + +void BackgroundIndexLoader::load(PathRef MainFile, + Back

[PATCH] D64712: [clangd] Refactor background-index shard loading

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/BackgroundIndexLoader.cpp:47 +// Stores the absolute paths for the direct dependencies of this file. +std::vector Edges; + }; I think we only need to traverse this when *missing*

[PATCH] D64712: [clangd] Refactor background-index shard loading

kadircet updated this revision to Diff 210564. kadircet added a comment. - Add comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64712/new/ https://reviews.llvm.org/D64712 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/c

[PATCH] D64712: [clangd] Refactor background-index shard loading

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/BackgroundIndexLoader.cpp:93 + +void BackgroundIndexLoader::load(PathRef MainFile, + BackgroundIndexStorage *Storage) { sammccall wrote: > This handles only

[PATCH] D64712: [clangd] Refactor background-index shard loading

kadircet updated this revision to Diff 210541. kadircet marked 5 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64712/new/ https://reviews.llvm.org/D64712 Files: clang-tools-ex

[PATCH] D64712: [clangd] Refactor background-index shard loading

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/Background.cpp:133 + if (!Buf) { +elog("Background-index: Couldn't read {0 to validate stored index: {1}", + LS.AbsolutePath, Buf.getError().message()); `{0` is missing its `

[PATCH] D64712: [clangd] Refactor background-index shard loading

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/Background.cpp:490 + auto FS = FSProvider.getFileSystem(); + llvm::DenseSet TUsToIndex; + for (auto &SI : Result.Shards) { sammccall wrote: > nit: again, this patch is adding Path/PathR

[PATCH] D64712: [clangd] Refactor background-index shard loading

kadircet updated this revision to Diff 210511. kadircet marked 13 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64712/new/ https://reviews.llvm.org/D64712 Files: clang-tools-e

[PATCH] D64712: [clangd] Refactor background-index shard loading

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64712 Files: clang-tools-extra/clangd/