This revision was automatically updated to reflect the committed changes.
Closed by commit rL366045: [clangd] Added highlighting to enum constants.
(authored by jvikstrom, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://rev
jvikstrom marked an inline comment as done.
jvikstrom added inline comments.
Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:257
+ case HighlightingKind::EnumConstant:
+return "constant.other.enum.cpp";
case HighlightingKind::Namespace:
hoke
hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:257
+ case HighlightingKind::EnumConstant:
+return "constant.other.enum.cpp";
case HighlightingKind:
jvikstrom updated this revision to Diff 209514.
jvikstrom marked 2 inline comments as done.
jvikstrom added a comment.
Address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64624/new/
https://reviews.llvm.org/D64624
Files:
clang-tools-
hokein added a comment.
mostly good.
Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:122
}
+if(isa(D)) {
+ addToken(Loc, HighlightingKind::EnumConstant);
nit: clang-format.
Comment at: clang-tools-extra/clangd/Sema
jvikstrom created this revision.
jvikstrom added reviewers: hokein, sammccall, ilya-biryukov.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay.
Herald added a project: clang.
VSCode does not have a scope for enum constants. So they were placed under
"constant.other.enum
