ABataev added a comment.
Fix the name of the patch. It is the patch for declare target, not target.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:2598-2599
+ DeviceID, FileID, Line);
+ OS << CGM.getMangledName(GlobalDecl(VD))
+ << llvm
gtbercea updated this revision to Diff 210645.
gtbercea added a comment.
- Address comments.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64592/new/
https://reviews.llvm.org/D64592
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
test/OpenMP/declare_target_codegen.cp
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:2589
HasRequiresUnifiedSharedMemory))) {
+llvm::GlobalValue::LinkageTypes GlobalVarLinkage =
+ CGM.getLLVMLinkageVarDefinition(VD, false);
Currently, I think,
