This revision was automatically updated to reflect the committed changes.
Closed by commit rL365882: [clangd] Don't run the prepare for tweaks that
are disabled. (authored by hokein, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
hokein updated this revision to Diff 209429.
hokein added a comment.
Address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64565/new/
https://reviews.llvm.org/D64565
Files:
clang-tools-extra/clangd/ClangdServer.cpp
clang-tools-extra/
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/ClangdServer.h:138
+std::function TweakFilter = [](const Tweak &T) {
+ return true; // always enabled all tweaks.
+
hokein added inline comments.
Comment at: clang-tools-extra/clangd/ClangdServer.h:136
-/// Returns true if the StringRef is a tweak that should be enabled
-std::function TweakFilter = [](llvm::StringRef
TweakToSearch) {return true;};
+/// Returns true if the String
hokein updated this revision to Diff 209223.
hokein marked 3 inline comments as done.
hokein added a comment.
Address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64565/new/
https://reviews.llvm.org/D64565
Files:
clang-tools-extra/cla
ilya-biryukov added inline comments.
Comment at: clang-tools-extra/clangd/ClangdServer.h:136
-/// Returns true if the StringRef is a tweak that should be enabled
-std::function TweakFilter = [](llvm::StringRef
TweakToSearch) {return true;};
+/// Returns true if the
hokein updated this revision to Diff 209216.
hokein added a comment.
Simplify the code further based on offline discussion.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64565/new/
https://reviews.llvm.org/D64565
Files:
clang-tools-extra/clangd/
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov.
Herald added a project: clang.
Previously, we ran the prepare, even for the tweaks that are disabled.
Repository:
rG LLVM Github Monorepo
https://re
