[PATCH] D64495: [AArch64] Implement __jcvt intrinsic from Armv8.3-A

ktkachov added a comment. In D64495#1587266 , @sammccall wrote: > FYI, this change broke git-llvm for everyone with a different username :-) > Fixed in r366198 Ah sorry, I accidentally included it in the commit! Repository: rL LLVM CHANGES SINCE LA

[PATCH] D64495: [AArch64] Implement __jcvt intrinsic from Armv8.3-A

sammccall added a comment. FYI, this change broke git-llvm for everyone with a different username :-) Fixed in r366198 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64495/new/ https://reviews.llvm.org/D64495 ___ cfe-c

[PATCH] D64495: [AArch64] Implement __jcvt intrinsic from Armv8.3-A

This revision was automatically updated to reflect the committed changes. Closed by commit rL366197: [AArch64] Implement __jcvt intrinsic from Armv8.3-A (authored by ktkachov, committed by ). Changed prior to commit: https://reviews.llvm.org/D64495?vs=209149&id=210051#toc Repository: rL LLVM

[PATCH] D64495: [AArch64] Implement __jcvt intrinsic from Armv8.3-A

ktkachov updated this revision to Diff 209149. ktkachov added a comment. Fix comments plus an offline comment I had (copy-pasto in an assert message) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64495/new/ https://reviews.llvm.org/D64495 Files: clang/include/clang/Basic/BuiltinsAArc

[PATCH] D64495: [AArch64] Implement __jcvt intrinsic from Armv8.3-A

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. Looks like a good change to me, some nits inlined. It shouldn't be difficult to request an account and commit it yourself, which might be useful if you maybe intend to submit more

[PATCH] D64495: [AArch64] Implement __jcvt intrinsic from Armv8.3-A

ktkachov updated this revision to Diff 208980. ktkachov added a comment. Add more CHECK-LABEL tests, test v8.4a and v8.5a features. Fix formatting in pattern. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64495/new/ https://reviews.llvm.org/D64495 Files: clang/include/clang/Basic/Bu

[PATCH] D64495: [AArch64] Implement __jcvt intrinsic from Armv8.3-A

SjoerdMeijer added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:720 def FJCVTZS : BaseFPToIntegerUnscaled<0b01, 0b11, 0b110, FPR64, GPR32, - "fjcvtzs", []> { + "fjcvtzs", [(set

[PATCH] D64495: [AArch64] Implement __jcvt intrinsic from Armv8.3-A

SjoerdMeijer added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:237 +break; + case llvm::AArch64::ArchKind::ARMV8_4A: +getTargetDefinesARMV84A(Opts, Builder); SjoerdMeijer wrote: > It is a good change, but I think you should either ad

[PATCH] D64495: [AArch64] Implement __jcvt intrinsic from Armv8.3-A

SjoerdMeijer added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:237 +break; + case llvm::AArch64::ArchKind::ARMV8_4A: +getTargetDefinesARMV84A(Opts, Builder); It is a good change, but I think you should either add tests for these case

[PATCH] D64495: [AArch64] Implement __jcvt intrinsic from Armv8.3-A

ktkachov created this revision. ktkachov added reviewers: t.p.northover, SjoerdMeijer, pbarrio, momchil.velikov. ktkachov added projects: LLVM, clang. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls, javed.absar. The __jcvt intrinsic defined in ACLE [1] is available