[PATCH] D64382: Use getMostFrequentByte to decide if should used memset+stores

2019-07-09 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka marked an inline comment as done. vitalybuka added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:873 return true; - if (isa(Init) || isa(Init) || + if (BWInit || isa(Init) || isa(Init) || isa(Init) || isa(Init) || vitalybuka w

[PATCH] D64382: Use getMostFrequentByte to decide if should used memset+stores

2019-07-09 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka marked 4 inline comments as done. vitalybuka added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:865 +/// initializer with equal or fewer than NumStores scalar stores. +static bool canEmitStoresForInitAfterMemset(CodeGenModule &CGM, +

[PATCH] D64382: Use getMostFrequentByte to decide if should used memset+stores

2019-07-09 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka updated this revision to Diff 208617. vitalybuka added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64382/new/ https://reviews.llvm.org/D64382 Files: clang/lib/CodeGen/CGDecl.cpp Index: clang/lib/CodeGen/CGDecl.cpp

[PATCH] D64382: Use getMostFrequentByte to decide if should used memset+stores

2019-07-08 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka updated this revision to Diff 208594. vitalybuka added a comment. undo some behavior change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64382/new/ https://reviews.llvm.org/D64382 Files: clang/lib/CodeGen/CGDecl.cpp Index: clang/lib

[PATCH] D64382: Use getMostFrequentByte to decide if should used memset+stores

2019-07-08 Thread JF Bastien via Phabricator via cfe-commits
jfb added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:865 +/// initializer with equal or fewer than NumStores scalar stores. +static bool canEmitStoresForInitAfterMemset(CodeGenModule &CGM, +llvm::Constant *Init, -

[PATCH] D64382: Use getMostFrequentByte to decide if should used memset+stores

2019-07-08 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka updated this revision to Diff 208583. vitalybuka added a comment. Reverted debug logging Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64382/new/ https://reviews.llvm.org/D64382 Files: clang/lib/CodeGen/CGDecl.cpp Index: clang/lib/Co

[PATCH] D64382: Use getMostFrequentByte to decide if should used memset+stores

2019-07-08 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka created this revision. vitalybuka added reviewers: eugenis, pcc, jfb. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. vitalybuka added a parent revision: D64111: Add getMostFrequentByte and use for isBytewiseValue implementation. Previous implementatio