[PATCH] D64270: [analyzer][NFC] Prepare visitors for different tracking kinds

This revision was automatically updated to reflect the committed changes. Closed by commit rL368777: [analyzer][NFC] Prepare visitors for different tracking kinds (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit

[PATCH] D64270: [analyzer][NFC] Prepare visitors for different tracking kinds

Szelethus updated this revision to Diff 211752. Szelethus added a comment. - Make sure that the tracking kind is forwarded for each invocation of `trackExpressionValue` in `BugReporterVisitor.cpp` - Expose the tracking kind to all users - Add some more docs CHANGES SINCE LAST ACTION https://r

[PATCH] D64270: [analyzer][NFC] Prepare visitors for different tracking kinds

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:81 + +bool bugreporter::trackExpressionValue(const ExplodedNode *InputNode, + const Expr *E, BugReport &report, Szelethus wrote: > x

[PATCH] D64270: [analyzer][NFC] Prepare visitors for different tracking kinds

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:110 + ConditionTracking +}; + Charusso wrote: > What about the following? > ``` > enum class Track

[PATCH] D64270: [analyzer][NFC] Prepare visitors for different tracking kinds

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:81 + +bool bugreporter::trackExpressionValue(const ExplodedNode *InputNode, + const Expr *E, BugReport &report, Do we need thi

[PATCH] D64270: [analyzer][NFC] Prepare visitors for different tracking kinds

Szelethus updated this revision to Diff 210337. Szelethus marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64270/new/ https://reviews.llvm.org/D64270 Files: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h clang/lib/StaticAnalyz

[PATCH] D64270: [analyzer][NFC] Prepare visitors for different tracking kinds

Charusso accepted this revision. Charusso added a comment. Document!!4!44! It is great you have started to limit the notes, thanks! Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:110 + ConditionTracking +}; + What about

[PATCH] D64270: [analyzer][NFC] Prepare visitors for different tracking kinds

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Approve! > null pointer dereference ...should in my opinion be tracked in a mild manner, as if it's a condition, because D62978 . I think the definition we're look

[PATCH] D64270: [analyzer][NFC] Prepare visitors for different tracking kinds

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, rnkovacs, Charusso, baloghadamsoftware, dcoughlin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. When we're tracki